[webkit-reviews] review requested: [Bug 110865] [GTK] Closing inspector window crashes wk : [Attachment 205995] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 3 05:55:57 PDT 2013


Alberto Garcia <agarcia at igalia.com> has asked  for review:
Bug 110865: [GTK] Closing inspector window crashes wk
https://bugs.webkit.org/show_bug.cgi?id=110865

Attachment 205995: Patch
https://bugs.webkit.org/attachment.cgi?id=205995&action=review

------- Additional Comments from Alberto Garcia <agarcia at igalia.com>
This happens because when we destroy priv->corePage in
webkit_web_view_dispose() we're triggering the deletion of
InspectorFrontendClient before it can clean up itself.

This can be fixed by waiting until the dispose method finishes before
actually destroying the corePage object. This way we ensure that the
webView's "destroy" signal is emitted first.


More information about the webkit-reviews mailing list