[webkit-reviews] review granted: [Bug 118334] Add overloading functions for is/toFooElement : [Attachment 205994] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 3 05:27:11 PDT 2013
Antti Koivisto <koivisto at iki.fi> has granted Kangil Han
<kangil.han at samsung.com>'s request for review:
Bug 118334: Add overloading functions for is/toFooElement
https://bugs.webkit.org/show_bug.cgi?id=118334
Attachment 205994: Patch
https://bugs.webkit.org/attachment.cgi?id=205994&action=review
------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=205994&action=review
> Source/WebCore/html/HTMLOptionElement.h:119
> +inline HTMLOptionElement* toHTMLOptionElement(Element* element)
> +{
> + ASSERT_WITH_SECURITY_IMPLICATION(!element ||
isHTMLOptionElement(element));
> + return static_cast<HTMLOptionElement*>(element);
> +}
> +
You don't really need the to* overloads.
More information about the webkit-reviews
mailing list