[webkit-reviews] review denied: [Bug 118307] [ATK] Leak: AtkAttributeSet* should be freed : [Attachment 205924] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 3 02:51:19 PDT 2013


Christophe Dumez <dchris at gmail.com> has denied Brian Holt
<brian.holt at samsung.com>'s request for review:
Bug 118307: [ATK] Leak: AtkAttributeSet* should be freed
https://bugs.webkit.org/show_bug.cgi?id=118307

Attachment 205924: Patch
https://bugs.webkit.org/attachment.cgi?id=205924&action=review

------- Additional Comments from Christophe Dumez <dchris at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=205924&action=review


> Source/WebCore/accessibility/atk/GOwnPtrAtk.cpp:2
> + *  Copyright (C) 2013 Samsung Electronics Inc.

We usually use "Samsung Electronics. All rights reserved."

> Source/WebCore/accessibility/atk/GOwnPtrAtk.cpp:27
> +

extra line

> Source/WebCore/accessibility/atk/GOwnPtrAtk.h:2
> + *  Copyright (C) 2013 Samsung Electronics Inc.

copyright

> Source/WebCore/accessibility/atk/GOwnPtrAtk.h:22
> +

No #if HAVE(ACCESSIBILITY)?


More information about the webkit-reviews mailing list