[webkit-reviews] review granted: [Bug 118337] Don't set z-index: 0 on lots of elements with -webkit-overflow-scrolling: touch : [Attachment 205964] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 2 19:59:57 PDT 2013


Benjamin Poulain <benjamin at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 118337: Don't set z-index: 0 on lots of elements with
-webkit-overflow-scrolling: touch
https://bugs.webkit.org/show_bug.cgi?id=118337

Attachment 205964: Patch
https://bugs.webkit.org/attachment.cgi?id=205964&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=205964&action=review


> Source/WebCore/css/StyleResolver.cpp:1534
> +    if ((isScrollableOverflow(style->overflowX()) ||
isScrollableOverflow(style->overflowY())) &&
style->useTouchOverflowScrolling())

Can you move style->useTouchOverflowScrolling() to be the first condition? (for
readability).


More information about the webkit-reviews mailing list