[webkit-reviews] review granted: [Bug 118322] TrailingObjects shouldn't shrink vector capacity in a loop : [Attachment 205943] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 2 15:28:15 PDT 2013


Darin Adler <darin at apple.com> has granted Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 118322: TrailingObjects shouldn't shrink vector capacity in a loop
https://bugs.webkit.org/show_bug.cgi?id=118322

Attachment 205943: Patch
https://bugs.webkit.org/attachment.cgi?id=205943&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=205943&action=review


> Source/WebCore/rendering/RenderBlockLineLayout.cpp:2742
> -    m_boxes.clear();
> +    m_boxes.shrink(0);

Why comment? It’s unclear that clear must not call clear.


More information about the webkit-reviews mailing list