[webkit-reviews] review granted: [Bug 118292] Move SVGTests attributes parsing to SVGGraphicsElement : [Attachment 205941] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Christophe Dumez <dchris at gmail.com>'s
request for review:
Bug 118292: Move SVGTests attributes parsing to SVGGraphicsElement
https://bugs.webkit.org/show_bug.cgi?id=118292

Attachment 205941: Patch
https://bugs.webkit.org/attachment.cgi?id=205941&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=205941&action=review


Is our test coverage for this good?

> Source/WebCore/svg/SVGGraphicsElement.cpp:119
> +    } else if (SVGTests::parseAttribute(name, value)) {
> +	   return;
>      }

WebKit coding style would make this a separate if statement ("no else after
return") and no braces around the single line "return" if body.