[webkit-reviews] review canceled: [Bug 118292] Move SVGTests attributes parsing to SVGGraphicsElement : [Attachment 205894] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has canceled Christophe Dumez
<dchris at gmail.com>'s request for review:
Bug 118292: Move SVGTests attributes parsing to SVGGraphicsElement
https://bugs.webkit.org/show_bug.cgi?id=118292

Attachment 205894: Patch
https://bugs.webkit.org/attachment.cgi?id=205894&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=205894&action=review


Some questions to the patch.

> Source/WebCore/svg/SVGSVGElement.cpp:255
> +bool SVGSVGElement::isSupportedAttribute(const QualifiedName& attrName)
> +{
> +    DEFINE_STATIC_LOCAL(HashSet<QualifiedName>, supportedAttributes, ());
> +    if (supportedAttributes.isEmpty()) {
> +	  
SVGExternalResourcesRequired::addSupportedAttributes(supportedAttributes);
> +	   SVGFitToViewBox::addSupportedAttributes(supportedAttributes);
> +	   SVGLangSpace::addSupportedAttributes(supportedAttributes);
> +	   SVGZoomAndPan::addSupportedAttributes(supportedAttributes);
> +	   supportedAttributes.add(SVGNames::xAttr);
> +	   supportedAttributes.add(SVGNames::yAttr);
> +	   supportedAttributes.add(SVGNames::widthAttr);
> +	   supportedAttributes.add(SVGNames::heightAttr);
> +	   supportedAttributes.add(SVGNames::onzoomAttr);
> +	   supportedAttributes.add(HTMLNames::onabortAttr);
> +	   supportedAttributes.add(HTMLNames::onerrorAttr);
> +	   supportedAttributes.add(HTMLNames::onunloadAttr);
> +	   supportedAttributes.add(HTMLNames::onresizeAttr);
> +	   supportedAttributes.add(HTMLNames::onscrollAttr);
> +    }
> +    return
supportedAttributes.contains<SVGAttributeHashTranslator>(attrName);

Can you explain this? Why did you add these elements here? They were not
removed anywhere else and are not part of SVGTest. Weren't they part of
SVGLocatable? Should also be described in the ChangeLog.