[webkit-reviews] review denied: [Bug 118316] Replace RELEASE_ASSERT with ASSERT in CodeBlock:: bytecodeOffsetForCallAtIndex : [Attachment 205935] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 2 12:13:45 PDT 2013
Geoffrey Garen <ggaren at apple.com> has denied Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 118316: Replace RELEASE_ASSERT with ASSERT in CodeBlock::
bytecodeOffsetForCallAtIndex
https://bugs.webkit.org/show_bug.cgi?id=118316
Attachment 205935: Patch
https://bugs.webkit.org/attachment.cgi?id=205935&action=review
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=205935&action=review
> Source/JavaScriptCore/bytecode/CodeBlock.h:228
> + ASSERT(index < m_rareData->m_callReturnIndexVector.size());
> + if (index < m_rareData->m_callReturnIndexVector.size())
I think you have this backwards?
More information about the webkit-reviews
mailing list