[webkit-reviews] review requested: [Bug 117998] need mechanism to detect (partially) hidden blocked plugins : [Attachment 205926] Patch to provide indication of (partially) hidden blocked plugin replacement elements

[bugzilla-daemon at webkit.org]

Gordon Sheridan <gordon_sheridan at apple.com> has asked  for review:
Bug 117998: need mechanism to detect (partially) hidden blocked plugins
https://bugs.webkit.org/show_bug.cgi?id=117998

Attachment 205926: Patch to provide indication of (partially) hidden blocked
plugin replacement elements
https://bugs.webkit.org/attachment.cgi?id=205926&action=review

------- Additional Comments from Gordon Sheridan <gordon_sheridan at apple.com>
I’ve tested the following scenarios:
	normal size/placement/visibility blocked plugin
	off the right side of the screen
	off the bottom of the screen
	off the top of the screen
	off the left of the screen
	covered by another element
	too small to display the replacement text
	low opacity (< 0.1)
	visibility: hidden

I set a conditional breakpoint that correctly triggers in all but the first
three scenarios.  In scenarios #2 and #3, I’m able to scroll the element on
screen where it can then be clicked.