[webkit-reviews] review granted: [Bug 118282] plainText() is O(N^2) : [Attachment 205923] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 118282: plainText() is O(N^2)
https://bugs.webkit.org/show_bug.cgi?id=118282

Attachment 205923: Patch
https://bugs.webkit.org/attachment.cgi?id=205923&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=205923&action=review


> Source/WTF/wtf/text/StringBuilder.cpp:35
> +static size_t expandCapacity(size_t capacity, size_t newLength)

I'm very much not sure about this function name. The function doesn't expand
any capacity, it only calculates one.

Perhaps something like bestCapacity? suggestedCapacity? expandedCapacity?