[webkit-reviews] review canceled: [Bug 118297] [ATK] Leak: leaks in AccessibilityUIElement : [Attachment 205916] Patch

[bugzilla-daemon at webkit.org]

Christophe Dumez <dchris at gmail.com> has canceled Brian Holt
<brian.holt at samsung.com>'s request for review:
Bug 118297: [ATK] Leak: leaks in AccessibilityUIElement
https://bugs.webkit.org/show_bug.cgi?id=118297

Attachment 205916: Patch
https://bugs.webkit.org/attachment.cgi?id=205916&action=review

------- Additional Comments from Christophe Dumez <dchris at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=205916&action=review


>>> Tools/ChangeLog:8
>>> +	     Reviewed by Christophe Dumez.
>> 
>> The patch did not get r+. So It is a bit early to update this line :)
> 
> Sorry, I didn't realise that we only do that after r+. Because I'm not a
committer I thought I could make the change to avoid having to upload another
patch after r+ ...

You don't have to reupload a patch after r+ unless there are nits to fix. This
line gets automatically updated when landing after a r+.

>>> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:425
>>> +	 GOwnPtr<gchar> axValue(g_strdup_printf("AXValue: %s",
textWithReplacedCharacters.get()));
>> 
>> Would you fix the same issue in
Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp in the
same patch please?
> 
> It turns out that this has already been fixed in WKTR, but it wasn't applied
to the DRT.

Oh, my bad. I misread my grep output.