[webkit-reviews] review granted: [Bug 112576] [Qt] An incremental build bug appeared after r145712. : [Attachment 195744] proposed patch

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at digia.com> has granted Ádám Kallai
<kadam at inf.u-szeged.hu>'s request for review:
Bug 112576: [Qt] An incremental build bug appeared after r145712.
https://bugs.webkit.org/show_bug.cgi?id=112576

Attachment 195744: proposed patch
https://bugs.webkit.org/attachment.cgi?id=195744&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=195744&action=review


>>> Source/WebCore/DerivedSources.pri:813
>>> +inspectorBackendCommands.depends = $$INSPECTOR_JSON
>> 
>> I'm not sure what this should fix, Inspector.json isn't a dependency of
InspectorBackendCommands.qrc
> 
> I agree, it is incorrect. But adding InspectorBackendCommands.js as
dependency
> can be a good workaround, because touching InspectorBackendCommands.js must
> force the regeneration of qrc_InspectorBackendCommands.cpp.

I see, InspectorBackendCommands.js is generated from Inspector.json, and
triggering a copy of the qrc in this case will work around the bug in qmake.

The patch looks fine to me after all, this is quite hackish though so it would
be nice to have a comment explaining how INSPECTOR_JSON is connected to
InspectorBackendCommands.qrc and why we do this.
r=me if you add such comment.