[webkit-reviews] review requested: [Bug 118293] [webkitpy] Add run-tests-touched-by-attachment command : [Attachment 205907] WIP patch

[bugzilla-daemon at webkit.org]

János Badics <jbadics at inf.u-szeged.hu> has asked  for review:
Bug 118293: [webkitpy] Add run-tests-touched-by-attachment command
https://bugs.webkit.org/show_bug.cgi?id=118293

Attachment 205907: WIP patch
https://bugs.webkit.org/attachment.cgi?id=205907&action=review

------- Additional Comments from János Badics <jbadics at inf.u-szeged.hu>
The tool can be run by
'Tools/Scripts/webkit-patch run-tests-touched-by-attachment [ATTACHMENT_ID]'

At the current state, the tool gets the paths of modified expected txt/png
files. Then it determines the filename without the '-expected' suffix and the
file extension. _test_relative_dir() determines the relative generic directory
path for the given test, e.g.
LayoutTests/platform/qt-5.0-wk1/editing/deleting/delete-cell-contents-expected.
txt ->
editing/deleting/
Then _tests_in_dir gets the paths of all the tests found in this directory. As
a last step, the loop in _first_generic_by_filename() gets the first match to
the given file name.
I know it's a bit ineffective, but we have to look up the extension for the
given test file name, since a lot of extensions are supported for test files
(htm, html, xhtml, etc.).

Further modifications are also needed, especially the ones recommended by
Ryosuke Niwa at https://bugs.webkit.org/show_bug.cgi?id=117831