[webkit-reviews] review denied: [Bug 100050] Font's fast code path doesn't handle partial runs correctly when kerning or ligatures are enabled : [Attachment 203806] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 2 04:54:04 PDT 2013
Antti Koivisto <koivisto at iki.fi> has denied Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 100050: Font's fast code path doesn't handle partial runs correctly when
kerning or ligatures are enabled
https://bugs.webkit.org/show_bug.cgi?id=100050
Attachment 203806: Patch
https://bugs.webkit.org/attachment.cgi?id=203806&action=review
------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=203806&action=review
> Source/WebCore/ChangeLog:9
> + Always let WidthIterator iterate over an entire TextRun to avoid
problems
> + with pixel rounding or shaping on partial runs.
This sounds like something that would regress performance. Please explain why
it wouldn't.
More information about the webkit-reviews
mailing list