[webkit-reviews] review denied: [Bug 118285] ToggleBold does not work in specific editable contents : [Attachment 205879] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied KyungTae Kim <ktf.kim at samsung.com>'s
request for review:
Bug 118285: ToggleBold does not work in specific editable contents
https://bugs.webkit.org/show_bug.cgi?id=118285

Attachment 205879: Patch
https://bugs.webkit.org/attachment.cgi?id=205879&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=205879&action=review


r- due to a lack of regression tests and inadequate change log description.

> Source/WebCore/ChangeLog:8
> +	   Check only the text that are visible when checking triStateOfStyle

This doesn't explain why we're making this code change.

A good change log entry describes what is causing the bug and how the
particular code change fixes it.
See http://www.webkit.org/coding/contributing.html for an example.

> Source/WebCore/ChangeLog:9
> +

We also need to add a test. You can automate bolding action via execCommand.
I also suspect you need to force Windows editing behavior via
internals.setEditingBehavior.