[webkit-reviews] review denied: [Bug 118288] vibrate function have to return boolean value. : [Attachment 205883] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 2 03:11:22 PDT 2013


Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied Kihong Kwon
<kihong.kwon at samsung.com>'s request for review:
Bug 118288: vibrate function have to return boolean value.
https://bugs.webkit.org/show_bug.cgi?id=118288

Attachment 205883: Patch
https://bugs.webkit.org/attachment.cgi?id=205883&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=205883&action=review


r- because of build error and my comment.

> Source/WebCore/ChangeLog:11
> +	   In addition, add maxVibrationDuration and maxVibrationPatternLength.


I think we need to handle this new variables on new bug because this patch is
not trivial.


More information about the webkit-reviews mailing list