[webkit-reviews] review denied: [Bug 109661] Implement CoordinatedSurface for Threaded Coordinated Graphics : [Attachment 205848] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has denied Jae Hyun Park
<jae.park at company100.net>'s request for review:
Bug 109661: Implement CoordinatedSurface for Threaded Coordinated Graphics
https://bugs.webkit.org/show_bug.cgi?id=109661

Attachment 205848: Patch
https://bugs.webkit.org/attachment.cgi?id=205848&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=205848&action=review


>
Source/WebCore/platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurfac
e.cpp:58
> +    GraphicsContext* context = beginPaint(rect);
> +    client->paintToSurfaceContext(context);
> +    endPaint();

It would be better if this was all in one function. Otherwise it may look like
beginPaint and endPaint can be called outside the context of paintToSurface.

>
Source/WebCore/platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurfac
e.cpp:77
> +#if USE(TEXTURE_MAPPER)

I think we can remove these in coordinated-graphics code.