[webkit-reviews] review granted: [Bug 118261] Web Inspector: link to WebInspectorUI normal now that it is open source : [Attachment 205833] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 118261: Web Inspector: link to WebInspectorUI normal now that it is open
source
https://bugs.webkit.org/show_bug.cgi?id=118261

Attachment 205833: Patch
https://bugs.webkit.org/attachment.cgi?id=205833&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=205833&action=review


r=me

> Source/Makefile:1
> +MODULES = WTF JavaScriptCore ThirdParty/ANGLE WebCore WebInspectorUI WebKit
WebKit2

Good catch!

> Tools/Scripts/build-webkit:231
> -    push @projects, ("Source/WebInspectorUI");
> +    # WebInspectorUI must come before WebKit and WebKit2
> +    unshift @projects, ("Source/WebInspectorUI");

So, unshift puts this at the front. So now WebInspectorUI happens before
anything (including ANGLE). It might be nice to do WebInspectorUI between
WebCore and WebKit. I think that logically makes more sense. But it doesn't
really matter.