[webkit-reviews] review denied: [Bug 118240] [Qt] Crash on close if build with geolocation : [Attachment 205806] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 118240: [Qt] Crash on close if build with geolocation
https://bugs.webkit.org/show_bug.cgi?id=118240

Attachment 205806: Patch
https://bugs.webkit.org/attachment.cgi?id=205806&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=205806&action=review


I am confused by this. I don't see when a GeolocationObject would outlive it's
page.

Can you add a test + an explanation of the case in the ChangeLog?

> Source/WebCore/ChangeLog:9
> +	   This also matches similar checkes elsewhere in Geolocation.

What?