[webkit-reviews] review denied: [Bug 118228] Build fix: use of long long in CoreIPC::ArgumentEncoder and CoreIPC::ArgumentDecoder : [Attachment 205785] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 1 07:34:42 PDT 2013


Anders Carlsson <andersca at apple.com> has denied Kwang Yul Seo
<skyul at company100.net>'s request for review:
Bug 118228: Build fix: use of long long in CoreIPC::ArgumentEncoder and
CoreIPC::ArgumentDecoder
https://bugs.webkit.org/show_bug.cgi?id=118228

Attachment 205785: Patch
https://bugs.webkit.org/attachment.cgi?id=205785&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=205785&action=review


> Source/WebCore/platform/network/BlobData.h:149
> -    long long offset;
> -    long long length;
> +    int64_t offset;
> +    int64_t length;
>      double expectedModificationTime;

I don't think we should change code in WebCore because of IPC requirements.


More information about the webkit-reviews mailing list