[webkit-reviews] review granted: [Bug 118150] Use DeferrableOneShotTimer for deleting decoded data : [Attachment 205803] don't call virtual in constructor

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 1 06:15:47 PDT 2013


Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 118150: Use DeferrableOneShotTimer for deleting decoded data
https://bugs.webkit.org/show_bug.cgi?id=118150

Attachment 205803: don't call virtual in constructor
https://bugs.webkit.org/attachment.cgi?id=205803&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=205803&action=review


Oh wow, now I feel stupid. :|

> Source/WebCore/loader/cache/CachedResource.cpp:185
> +static double
decodedDataDeletionTimerDelayForResourceType(CachedResource::Type type)

We should call this deadDecodedDataDeletionIntervalForResourceType() to match
the MemoryCache function.


More information about the webkit-reviews mailing list