[webkit-reviews] review granted: [Bug 118235] Adopt is/toHTMLMapElement for code cleanup : [Attachment 205796] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 1 04:38:59 PDT 2013


Andreas Kling <akling at apple.com> has granted Kangil Han
<kangil.han at samsung.com>'s request for review:
Bug 118235: Adopt is/toHTMLMapElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118235

Attachment 205796: Patch
https://bugs.webkit.org/attachment.cgi?id=205796&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
r=me

It's a little bit unfortunate that the isFooElement(Node*) helpers incur the
cost of an isElementNode() check that wouldn't be necessary if the argument
were an Element*. Perhaps we could templatize the method so the compiler would
skip the check when the argument is of a narrower type. Food for thought.


More information about the webkit-reviews mailing list