[webkit-reviews] review granted: [Bug 108579] [V8] Remove V8GCController::m_edenNodes and make minor DOM GC more precise : [Attachment 185947] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 108579: [V8] Remove V8GCController::m_edenNodes and make minor DOM GC more
precise
https://bugs.webkit.org/show_bug.cgi?id=108579

Attachment 185947: Patch
https://bugs.webkit.org/attachment.cgi?id=185947&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185947&action=review


> Source/WebCore/bindings/v8/DOMDataStore.h:172
>      {
>	   ASSERT(object->wrapper().IsEmpty());
>	   object->setWrapper(wrapper);
> -	   V8GCController::didCreateWrapperForNode(object);
>	   wrapper.MakeWeak(static_cast<ScriptWrappable*>(object),
weakCallback);
>      }

We can now delete this whole function and use the ScriptWrappable version of
setWrapperInObject instead.

> Source/WebCore/bindings/v8/V8GCController.cpp:199
> +		   // The fact that we encounter a node that is not in the Eden
space

Should this comment still refer to Eden now that we've removed that concept?