[webkit-reviews] review requested: [Bug 108565] [CPP, GObject, ObjC] Add 'enum' skip to CodeGenerator{CPP, GObject, ObjC}.pm : [Attachment 185941] Patch

[bugzilla-daemon at webkit.org]

Nils Barth <nbarth at google.com> has asked  for review:
Bug 108565: [CPP,GObject,ObjC] Add 'enum' skip to
CodeGenerator{CPP,GObject,ObjC}.pm
https://bugs.webkit.org/show_bug.cgi?id=108565

Attachment 185941: Patch
https://bugs.webkit.org/attachment.cgi?id=185941&action=review

------- Additional Comments from Nils Barth <nbarth at google.com>
(In reply to comment #2)
> (From update of attachment 185936 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=185936&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +	     Add IsEnumType test to SkipAttribute in legacy code generators.
> 
> Please explain the rationale for the change, not only what you did but also
why you did it.
> 
> e.g. Since CodeGenerator{CPP,GObject,ObjC}.pm does not support 'enum', this
patch adds code to skip DOM attributes that return 'enum'.
Got it -- fixed.