[webkit-reviews] review granted: [Bug 108403] [CSS Grid Layout] computePreferredLogicalWidths doesn't handle minmax tracks : [Attachment 185910] Proposed fix 2: Updated after Ojan's comments.

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 108403: [CSS Grid Layout] computePreferredLogicalWidths doesn't handle
minmax tracks
https://bugs.webkit.org/show_bug.cgi?id=108403

Attachment 185910: Proposed fix 2: Updated after Ojan's comments.
https://bugs.webkit.org/attachment.cgi?id=185910&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185910&action=review


> Source/WebCore/rendering/RenderGrid.cpp:164
> +LayoutUnit RenderGrid::resolvePreferredLogicalWidth(const Length& length,
size_t trackIndex) const

Didn't notice this in the last patch. This might be a bit more consistent with
RenderBox if you called this computePreferredTrackWidthUsing or something like
that (e.g. see RenderBox::computeLogicalHeightUsing). resolve is a fairly
overloaded verb. :)

> Source/WebCore/rendering/RenderGrid.cpp:200
> +    // (including <percentage> and calc()) but we don't it elsewhere.

Missing a word or two here. :)