[webkit-reviews] review denied: [Bug 102580] [chromium] Short scrollbar has empty track rect even when buttons have no size. : [Attachment 177165] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Robert Flack
<flackr at chromium.org>'s request for review:
Bug 102580: [chromium] Short scrollbar has empty track rect even when buttons
have no size.
https://bugs.webkit.org/show_bug.cgi?id=102580

Attachment 177165: Patch
https://bugs.webkit.org/attachment.cgi?id=177165&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177165&action=review


So this is a UI feature request?  Is there a link somewhere to a bug or
discussion of the actual vs expected behaviors?

> LayoutTests/platform/chromium/scrollbars/short-scrollbar-expected.txt:1
> +layer at (0,0) size 800x600

you don't need a layer tree dump here, just the pixels. call
testRunner.dumpAsText(true) in a script block inside the test to get this
output

> LayoutTests/platform/chromium/scrollbars/short-scrollbar.html:4
> +<!-- On platforms with no scrollbar button images we should draw the native
scrollbar track even when the scrollbar is very short. -->

I don't understand how this comment matches up with the -expected.png in this
patch.	I see buttons.