[webkit-reviews] review granted: [Bug 108509] [Chromium] Select multi-word misspelling on context click : [Attachment 185887] Patch for landing

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Rouslan Solomakhin
<rouslan+webkit at chromium.org>'s request for review:
Bug 108509: [Chromium] Select multi-word misspelling on context click
https://bugs.webkit.org/show_bug.cgi?id=108509

Attachment 185887: Patch for landing
https://bugs.webkit.org/attachment.cgi?id=185887&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185887&action=review


I had suggested moving in a follow up change because now the diff doesn't show
your changes.  Anyway, this is OK too.

> Source/WebKit/chromium/src/ContextMenuClientImpl.cpp:149
> +// Helper function to get misspelling on which context menu is to be invoked

> +// for asynchronous spellcheck. This function changes the selection only
when
> +// there were no selected characters.

Remove this comment.

> Tools/DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:120
> +    if (word == WebString::fromUTF8("wellcome"))
> +	   append(suggestions, WebString::fromUTF8("welcome"));

Why do we copy and swap?  Why can't we append to |suggestions| directly?