[webkit-reviews] review granted: [Bug 108533] Abstraction for hiding enum class : [Attachment 185879] the patch.

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Mark Lam
<mark.lam at apple.com>'s request for review:
Bug 108533: Abstraction for hiding enum class
https://bugs.webkit.org/show_bug.cgi?id=108533

Attachment 185879: the patch.
https://bugs.webkit.org/attachment.cgi?id=185879&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=185879&action=review


> Source/WTF/wtf/EnumClass.h:92
> +    ALWAYS_INLINE EnumClass() : m_value(static_cast<Value>(0)) { }
> +    ALWAYS_INLINE EnumClass(Value value) : m_value(value) { }

Thinking some more about this, I don't think it's a good idea to have a default
value. 

In C++11, MyEnum value1 would just get a random value, and we don't want that
to differ between C++11 and C++98.