[webkit-reviews] review granted: [Bug 108509] [Chromium] Select two-word misspelling on context-click : [Attachment 185850] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Rouslan Solomakhin
<rouslan+webkit at chromium.org>'s request for review:
Bug 108509: [Chromium] Select two-word misspelling on context-click
https://bugs.webkit.org/show_bug.cgi?id=108509

Attachment 185850: Patch
https://bugs.webkit.org/attachment.cgi?id=185850&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185850&action=review


As a follow up, it would be nice if we moved the spellchecking code into a
helper function out of getCustomMenuFromDefaultItems() since that function is >
200 lines.

> Source/WebKit/chromium/src/ContextMenuClientImpl.cpp:295
> +		       if (markerRange->startOffset() ==
selectionRange->startOffset() && markerRange->endOffset() ==
selectionRange->endOffset()) {

Could you use WebCore::areRangesEqual() here instead of comparing start and
end?