[webkit-reviews] review granted: [Bug 108395] Provide a sensible default architecture when building on iOS SDKs : [Attachment 185673] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted David Farler
<dfarler at apple.com>'s request for review:
Bug 108395: Provide a sensible default architecture when building on iOS SDKs
https://bugs.webkit.org/show_bug.cgi?id=108395

Attachment 185673: Patch
https://bugs.webkit.org/attachment.cgi?id=185673&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185673&action=review


r=me, but consider cleaning up the line in XcodeOptions.

> Tools/Scripts/webkitdirs.pm:556
> +    return (@baseProductDirOption, "-configuration", $configuration,
($architecture ? "ARCHS=$architecture" : ()),($xcodeSDK ? "SDKROOT=$xcodeSDK" :
()), argumentsForXcode());

It would be nice to pull out the ARCHS and SDKROOT ternaries into their own
lines to make this line to enhance readability.