[webkit-reviews] review granted: [Bug 91665] When a block element is made inline positioned and has static left and right, it does not follow inline formatting context : [Attachment 180385] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Pravin D
<pravind.2k4 at gmail.com>'s request for review:
Bug 91665: When a block element is made inline positioned and has static left
and right,  it does not follow inline formatting context
https://bugs.webkit.org/show_bug.cgi?id=91665

Attachment 180385: Patch
https://bugs.webkit.org/attachment.cgi?id=180385&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180385&action=review


r=me, thanks for sticking to the end. I don't need to see the updated change.

It seems this could potentially impact the bots so I will let you cq it when
you are ready.

> Source/WebCore/dom/Node.cpp:388
> +    if (wasFloating != isFloating || wasOutOfFlowPositioned !=
isOutOfFlowPositioned)

Shouldn't we check:

if ((s1 && s2) && (wasFloating != isFloating || wasOutOfFlowPositioned !=
isOutOfFlowPositioned))

which would be better written:

if ((s1 && s2) && (s1->isFloating() != s2->isFloating() ||
s1->hasOutOfFlowPosition() != s2->hasOutOfFlowPosition())

This would prevent the first recalcStyle to detach the renderer.