[webkit-reviews] review granted: [Bug 108514] Get rid of IncomingMessage : [Attachment 185838] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 31 12:38:22 PST 2013
Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 108514: Get rid of IncomingMessage
https://bugs.webkit.org/show_bug.cgi?id=108514
Attachment 185838: Patch
https://bugs.webkit.org/attachment.cgi?id=185838&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185838&action=review
> Source/WebKit2/Platform/CoreIPC/Connection.cpp:92
> + // FIXME: This should really an be OwnPtr,
> + // but we need Vector to work with move semantics first.
The bug here is https://bugs.webkit.org/show_bug.cgi?id=87594. But, is this
really true. Can't you use VectorTraits? Vector already knows how to work
with OwnPtr for instance.
More information about the webkit-reviews
mailing list