[webkit-reviews] review granted: [Bug 86418] CSS3's vh attribute is not adjusting while browser resizes : [Attachment 185703] Proposed patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Uday Kiran
<udaykiran at motorola.com>'s request for review:
Bug 86418: CSS3's vh attribute is not adjusting while browser resizes
https://bugs.webkit.org/show_bug.cgi?id=86418

Attachment 185703: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=185703&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=185703&action=review


Looks good otherwise.

> Source/WebCore/ChangeLog:24
> +	   (WebCore::RenderBoxModelObject::calculateFillTileSize): Fixed an
error in
> +	   initial implementation of vw/vh/vmin.

Please file a separate bug for this. You should fix it in a separate patch with
a test case.