[webkit-reviews] review granted: [Bug 107737] Editor::m_compositionNode not updated on HTMLInputElement::setValue() : [Attachment 185821] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 31 12:00:07 PST 2013


Ryosuke Niwa <rniwa at webkit.org> has granted Aurimas Liutikas
<aurimas at chromium.org>'s request for review:
Bug 107737: Editor::m_compositionNode not updated on
HTMLInputElement::setValue()
https://bugs.webkit.org/show_bug.cgi?id=107737

Attachment 185821: Patch
https://bugs.webkit.org/attachment.cgi?id=185821&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185821&action=review


> Source/WebKit/win/WebView.cpp:5486
> +    if (!targetFrame)
>	   return;

I don't think focusedOrMainFrame can ever be null and it's obnoxious that it
even checks this condition but that's a separate issue.


More information about the webkit-reviews mailing list