[webkit-reviews] review granted: [Bug 108498] [Chromium] Add two-word misspelling to mock spellchecker : [Attachment 185809] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Rouslan Solomakhin
<rouslan+webkit at chromium.org>'s request for review:
Bug 108498: [Chromium] Add two-word misspelling to mock spellchecker
https://bugs.webkit.org/show_bug.cgi?id=108498

Attachment 185809: Patch
https://bugs.webkit.org/attachment.cgi?id=185809&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185809&action=review


You can use "webkit-patch land-safely" to reupload the patch and forward on the
r+.

> Tools/DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:76
> +	   int maxWordLength = static_cast<int>(stringText.length()) -
wordOffset;
> +	   int wordLength;

I think you would have fewer casts if you made all the length types unsigned. 
Conceptually, a negative length doesn't make sense.

> Tools/DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:167
> +	   m_misspelledWords.append(WTF::String::fromUTF8(misspelledWords[i]));


Nit: remove WTF::

> Tools/DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:73
> +    Vector<WTF::String> m_misspelledWords;

Nit: remove WTF::