[webkit-reviews] review denied: [Bug 107883] Web Inspector: Add support for handling modal dialogs : [Attachment 185791] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 31 09:47:27 PST 2013
Pavel Feldman <pfeldman at chromium.org> has denied Ken Kania
<kkania at chromium.org>'s request for review:
Bug 107883: Web Inspector: Add support for handling modal dialogs
https://bugs.webkit.org/show_bug.cgi?id=107883
Attachment 185791: Patch
https://bugs.webkit.org/attachment.cgi?id=185791&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185791&action=review
A couple of renames and it is good to go.
> Source/WebCore/inspector/Inspector.json:556
> + "name": "willRunJavaScriptDialog",
Protocol naming that you had earlier was correct. Yury's comment was only about
the InspectorInstrumentation.
More information about the webkit-reviews
mailing list