[webkit-reviews] review denied: [Bug 108456] Web Inspector: Exception in HeapSnapshotView.js : [Attachment 185747] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied  review:
Bug 108456: Web Inspector: Exception in HeapSnapshotView.js
https://bugs.webkit.org/show_bug.cgi?id=108456

Attachment 185747: Patch
https://bugs.webkit.org/attachment.cgi?id=185747&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185747&action=review


> Source/WebCore/inspector/front-end/HeapSnapshotView.js:741
> +	   if (!event.data || event.data.type !==
WebInspector.HeapSnapshotProfileType.TypeId)

This one will not work for native snapshots with type
WebInspector.NativeSnapshotProfileType.TypeId which reuses the same view so we
should probably save profile type from the |profile| argument to
HeapSnapshotView and compare with it here.