[webkit-reviews] review granted: [Bug 108384] TextAutosizing: refactor the cluster related method parameters into a single struct : [Attachment 185655] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 31 02:24:21 PST 2013


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Anton Vayvod
<avayvod at chromium.org>'s request for review:
Bug 108384: TextAutosizing: refactor the cluster related method parameters into
a single struct
https://bugs.webkit.org/show_bug.cgi?id=108384

Attachment 185655: Patch
https://bugs.webkit.org/attachment.cgi?id=185655&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185655&action=review


im ok with this, but I also dont see any big value in the change. Could you
explain what you will be adding in the future?

> Source/WebCore/ChangeLog:5
> +	   TextAutosizing: refactor the cluster related method parameters into
a single struct.
> +	   This anticipates adding more cluster related information in the
following patches.
> +	   https://bugs.webkit.org/show_bug.cgi?id=108384

You should only have the bugtitle here and then the bug link.


More information about the webkit-reviews mailing list