[webkit-reviews] review requested: [Bug 108431] webdatabase: Clean up calls to DatabaseTracker::add/removeOpenDatabase() : [Attachment 185719] a better patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 31 01:53:42 PST 2013


Mark Lam <mark.lam at apple.com> has asked  for review:
Bug 108431: webdatabase: Clean up calls to
DatabaseTracker::add/removeOpenDatabase()
https://bugs.webkit.org/show_bug.cgi?id=108431

Attachment 185719: a better patch.
https://bugs.webkit.org/attachment.cgi?id=185719&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
Fixed chromium build failure.  Also used RAII pattern to call
DatabaseTracker::doneCreatingDatabase() on exit.  To do this, I also need to
remove the call to doneCreatingDatabase() from addOpenDatabase(), which
actually makes it cleaner.  Please review.  Thanks.


More information about the webkit-reviews mailing list