[webkit-reviews] review granted: [Bug 108434] Rename WheelEvent::Granularity to WheelEvent::DeltaMode : [Attachment 185685] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 108434: Rename WheelEvent::Granularity to WheelEvent::DeltaMode
https://bugs.webkit.org/show_bug.cgi?id=108434

Attachment 185685: Patch
https://bugs.webkit.org/attachment.cgi?id=185685&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185685&action=review


rs=me but please fix the build before you land it.

> Source/WebCore/dom/WheelEvent.cpp:56
> +    DeltaMode deltaMode, PassRefPtr<AbstractView> view,
> +    const IntPoint& screenLocation, const IntPoint& pageLocation,
> +    bool ctrlKey, bool altKey, bool shiftKey, bool metaKey,
> +    bool directionInvertedFromDevice)

It seems like we can fit all of this in two lines if not one?