[webkit-reviews] review granted: [Bug 108418] PDFPlugin: Should respond to three-finger tap for dictionary definitions : [Attachment 185661] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 108418: PDFPlugin: Should respond to three-finger tap for dictionary
definitions
https://bugs.webkit.org/show_bug.cgi?id=108418

Attachment 185661: patch
https://bugs.webkit.org/attachment.cgi?id=185661&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=185661&action=review


> Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:935
> +    if ([lookupSelection string] && [[lookupSelection string]
isNotEqualTo:@""])

Better to test [[lookupSelection string] length], which you can do without
null-checking [lookupSelection string]