[webkit-reviews] review requested: [Bug 108263] formMethod to have empty string as default value and 'get' as invalid. : [Attachment 185658] updated_patch

[bugzilla-daemon at webkit.org]

Vineet Chaudhary (vineetc) <rgf748 at motorola.com> has asked  for review:
Bug 108263: formMethod to have empty string as default value and 'get' as
invalid.
https://bugs.webkit.org/show_bug.cgi?id=108263

Attachment 185658: updated_patch
https://bugs.webkit.org/attachment.cgi?id=185658&action=review

------- Additional Comments from Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>
(In reply to comment #9)
> > Source/WebCore/html/HTMLFormControlElement.cpp:92
> > +	     return String();
> 
> Why did you change this line to String(), not emptyString() Darin
recommended?

I interpreted it wrong. Done!!
 
> > LayoutTests/fast/forms/formmethod-attribute-test.html:21
> > +shouldBe('ip1.formMethod', '""');
> 
> Please use shouldBeEqualToString to avoid ugly nested quotes.

Done. There are still calls shouldBe() instead of shouldBeEqualToString()
in another file ../forms/submit-form-attributes.html in this patch but I wasn't
sure to change those
but I can do that in followup patch for formenctype if required.

> > Source/WebCore/ChangeLog:4
> > +	     https://bugs.webkit.org/show_bug.cgi?id=108263
> > +	     formMethod to have empty string as default value and 'get' as
invalid.
> Please put the description line first.

Done. Thank you for comments.