[webkit-reviews] review granted: [Bug 108351] [CSS Shaders] Parse custom filter function with the at-rule reference syntax : [Attachment 185526] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 30 18:48:50 PST 2013
Dean Jackson <dino at apple.com> has granted Max Vujovic <mvujovic at adobe.com>'s
request for review:
Bug 108351: [CSS Shaders] Parse custom filter function with the at-rule
reference syntax
https://bugs.webkit.org/show_bug.cgi?id=108351
Attachment 185526: Patch
https://bugs.webkit.org/attachment.cgi?id=185526&action=review
------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=185526&action=review
> Source/WebCore/css/CSSParser.cpp:8309
> + argsList->next();
> +
> + if (!(arg = argsList->current()))
You could write this as:
arg = argsList->next();
if (!arg)
Maybe I just dislike assignments in conditionals :)
More information about the webkit-reviews
mailing list