[webkit-reviews] review denied: [Bug 107778] Objective-C API: JSContext exception property causes reference cycle : [Attachment 185587] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 30 17:39:02 PST 2013


Gavin Barraclough <barraclough at apple.com> has denied  review:
Bug 107778: Objective-C API: JSContext exception property causes reference
cycle
https://bugs.webkit.org/show_bug.cgi?id=107778

Attachment 185587: Patch
https://bugs.webkit.org/attachment.cgi?id=185587&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=185587&action=review


r- for protect issue Geoff identified.

> Source/JavaScriptCore/API/JSContext.mm:93
> +	   m_exception = nil;

I think we only use nil for Objective-C pointer types; this should probably by
0.


More information about the webkit-reviews mailing list