[webkit-reviews] review denied: [Bug 108376] [Gtk] drag and drop has black background without composition : [Attachment 185612] updated patch: no need for a ManualTest

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied arno. <arno at renevier.net>'s
request for review:
Bug 108376: [Gtk] drag and drop has black background without composition
https://bugs.webkit.org/show_bug.cgi?id=108376

Attachment 185612: updated patch: no need for a ManualTest
https://bugs.webkit.org/attachment.cgi?id=185612&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185612&action=review


Looks great, just needs a teensy bit of cleaning up.

> Source/WebCore/platform/gtk/DragIcon.cpp:56
> +#ifdef GTK_API_VERSION_2
> +    , m_pixbuf(0)
> +#endif

This can be eliminated with a GRefPtr. See below.

> Source/WebCore/platform/gtk/DragIcon.cpp:89
> +#ifdef GTK_API_VERSION_2
> +    if (m_pixbuf)
> +	   g_object_unref(m_pixbuf);
> +#endif

Instead of a raw pointer you could use a GRefPtr here.

> Source/WebCore/platform/gtk/DragIcon.cpp:116
> +#ifdef GTK_API_VERSION_2
> +    if (m_pixbuf)
> +	   g_object_unref(m_pixbuf);
> +    m_pixbuf = cairoImageSurfaceToGdkPixbuf(image);
> +#endif

This would become:

m_pixbuf = adoptGRef(cairoImageSurfaceToGdkPixbuf(image));

> Source/WebCore/platform/gtk/DragIcon.h:45
> +    gboolean m_iscomposited;

This should probably be:

bool isComposited;