[webkit-reviews] review denied: [Bug 108259] Coordinated Graphics : Remove WebCoordinatedSurface dependency from CoordinatedSurface : [Attachment 185456] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Jae Hyun Park
<jae.park at company100.net>'s request for review:
Bug 108259: Coordinated Graphics : Remove WebCoordinatedSurface dependency from
CoordinatedSurface
https://bugs.webkit.org/show_bug.cgi?id=108259

Attachment 185456: Patch
https://bugs.webkit.org/attachment.cgi?id=185456&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185456&action=review


I sign off on this change, Noam can review this for WebKit2.

> Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedSurface.cpp:18
> +/*
> + Copyright (C) 2013 Company 100, Inc.
> +
> + This library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Library General Public
> + License as published by the Free Software Foundation; either
> + version 2 of the License, or (at your option) any later version.
> +
> + This library is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + Library General Public License for more details.
> +
> + You should have received a copy of the GNU Library General Public License
> + along with this library; see the file COPYING.LIB.	If not, write to
> + the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
> + Boston, MA 02110-1301, USA.
> + */

Not the standard header.

> Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedSurface.cpp:24
> +#include "config.h"
> +
> +#if USE(COORDINATED_GRAPHICS)
> +
> +#include "CoordinatedSurface.h"

Should be:

#include "config.h"
#include "CoordinatedSurface.h"

#if FOOBAR

> Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedSurface.cpp:43
> +#endif // USE(COORDINATED_GRAPHICS)
> +
> +} // namespace WebKit

the #define does not match the namespace scope.

>
Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.
h:119
> +    // CoordinatedSurface

Useless comment.