[webkit-reviews] review granted: [Bug 108215] [GTK] Add WTFURL source files to the build : [Attachment 185291] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 108215: [GTK] Add WTFURL source files to the build
https://bugs.webkit.org/show_bug.cgi?id=108215

Attachment 185291: Patch
https://bugs.webkit.org/attachment.cgi?id=185291&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185291&action=review


> Source/WebCore/ChangeLog:8
> +	   No new tests (OOPS!).

You should remove this line.

> Source/WebCore/platform/KURLWTFURL.cpp:-287
> -// FIXME: Get rid of this function from KURL.
> -String KURL::fileSystemPath() const
> -{
> -    return string();
> -}

I think that is gonna break the Mac build with WTFURL.

> Source/autotools/symbols.filter:243
> +_ZNK7WebCore4KURL6stringEv;

Shouldn't this be guarded by an #ifdef? Maybe you do not preprocess the symbols
on GTK?

> ChangeLog:17
> +2013-01-29  Zan Dobersek  <zdobersek at igalia.com>
> +
> +	   [GTK] Add WTFURL source files to the build
> +	   https://bugs.webkit.org/show_bug.cgi?id=108215
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * Source/autotools/symbols.filter:
> +
> +2013-01-29  Zan Dobersek  <zdobersek at igalia.com>
> +
> +	   [GTK] Add WTFURL source files to the build
> +	   https://bugs.webkit.org/show_bug.cgi?id=108215
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * Source/autotools/symbols.filter: Force exporting the
KURL::string() symbol

Double changelog.