[webkit-reviews] review denied: [Bug 107804] [mac] ImageBuffer should create accelerated buffers for small canvases, but we shouldn't force them to create compositing layers : [Attachment 185582] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 30 14:52:53 PST 2013


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 107804: [mac] ImageBuffer should create accelerated buffers for small
canvases, but we shouldn't force them to create compositing layers
https://bugs.webkit.org/show_bug.cgi?id=107804

Attachment 185582: patch
https://bugs.webkit.org/attachment.cgi?id=185582&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=185582&action=review


> Source/WTF/wtf/Platform.h:1218
> +#if !PLATFORM(MAC) && !PLATFORM(IOS)
> +#define WTF_USE_COMPOSITING_FOR_SMALL_CANVASES 1
> +#endif

Please don't cause megawatts of energy use in making us all rebuild because of
this #ifdef that's only used in one place.


More information about the webkit-reviews mailing list