[webkit-reviews] review granted: [Bug 108380] Apple's internal PLT test suite doesn't finish after r141136 : [Attachment 185564] Temporarily disable the feature

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 108380: Apple's internal PLT test suite doesn't finish after r141136
https://bugs.webkit.org/show_bug.cgi?id=108380

Attachment 185564: Temporarily disable the feature
https://bugs.webkit.org/attachment.cgi?id=185564&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185564&action=review


r=me

We should make a reproducible case that's not internal.

> Source/WebCore/loader/cache/CachedResourceLoader.cpp:482
> +#if PLATFORM(CHROMIUM) || PLATFORM(MAC)
>      // FIXME: Temporarily leave main resource caching disabled for chromium,
see https://bugs.webkit.org/show_bug.cgi?id=107962
>      // Ensure main resources aren't preloaded, and other main resource loads
are removed from cache to prevent reuse.

Please add a comment about Mac here.