[webkit-reviews] review denied: [Bug 107701] Canvas and DOM go out of sync : [Attachment 185551] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied sugoi at chromium.org's
request for review:
Bug 107701: Canvas and DOM go out of sync
https://bugs.webkit.org/show_bug.cgi?id=107701

Attachment 185551: Patch
https://bugs.webkit.org/attachment.cgi?id=185551&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=185551&action=review


> Source/WebCore/rendering/RenderLayer.cpp:386
> +#if USE(ACCELERATED_COMPOSITING)
> +    if ((flags & UpdateCompositingLayers) && rootLayer && (rootLayer !=
this) && rootLayer->isComposited()) {
> +	   RenderLayerBacking::UpdateAfterLayoutFlags updateFlags =
RenderLayerBacking::CompositingChildrenOnly;
> +	   if (flags & NeedsFullRepaintInBacking)
> +	       updateFlags |= RenderLayerBacking::NeedsFullRepaint;
> +	   if (flags & IsCompositingUpdateRoot)
> +	       updateFlags |= RenderLayerBacking::IsUpdateRoot;
> +	   rootLayer->backing()->updateAfterLayout(updateFlags);
> +    }

What does this do that the later updateCompositingLayersAfterLayout() call in
FrameView::layout() does not?

Your changelog needs to convince me that you understand the underlying cause
for this bug. This feels like wallpapering over the cracks.